fix: avoid deprecation messages for PHP 8.4#834
fix: avoid deprecation messages for PHP 8.4#834tiwarishubham635 merged 8 commits intotwilio:mainfrom
Conversation
|
Is there anything I need to do to get this merged? Thanks. |
This reverts commit aa90ec7. fix: Reverted depreciation change for PHPUnit fix: PHP 8.4 support added
|
Be nice to get this merged in and versioned. Anyone that isn't ignoring deprecations will be blocked from using 8.4 |
|
@phpfui can you get the tests passing here? I don't know what's up with the Twilio team - guess still on vacation... |
|
I have not seen this prefix thing before, but looks like it works now. Can we get a merge here to support 8.4? PHP 8.4 was released two months ago. |
|
Hi! Let me review this once |
tiwarishubham635
left a comment
There was a problem hiding this comment.
The changes look more or less good to me. Can you please verify once of the places where ? needs to be added? Also, do we really need to give ?string $contentType = null, or can we straightaway write ?string $contentType and use nullable types? Please check once
|
Also, please add PHP 8.4 to the test-suite. Based on my comment above, I suspect the deprecations are not fully resolved. |
|
I did not see any other depreciations when running PHPUnit with PHP 8.4, so I think we are good assuming your tests have 100% code coverage. |
tiwarishubham635
left a comment
There was a problem hiding this comment.
Looks good to me
|
Reverted these changes due to failing tests - https://github.com/twilio/twilio-php/actions/runs/12664947059/job/35293855625 |
Fixes
This PR makes the minimal changes needed to avoid depreciation messages for PHP 8.4. It does not contain any logic changes:
All changes should be compatible with PHP 7.1, which is the lowest supported PHP version.
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.