Skip to content

Conversation

pankaj-bind
Copy link

@pankaj-bind pankaj-bind commented Jun 30, 2025

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

This pull request adds new unit tests to tsdef/twilio-video-tests.ts to improve the robustness of our TypeScript definitions.

Description:

The CHANGELOG.md indicates that there have been several fixes related to TypeScript definition errors in the past (e.g., VIDEO-12242, VIDEO-12383). To prevent regressions and ensure the long-term stability of our TypeScript definitions, this PR introduces new unit tests for the following:

  • AudioTrack
  • VideoTrack
  • LocalTrackOptions

These tests will help us catch any incorrect or missing definitions for methods like AudioTrack.attach(), VideoTrack.attach(), and createLocalAudioTrack(). By adding these tests, we can ensure that our TypeScript definitions remain accurate and reliable as the SDK evolves.

Changes:

  • Added new test cases to tsdef/twilio-video-tests.ts to cover AudioTrack, VideoTrack, and LocalTrackOptions.
  • Corrected minor typing issues in the test file to ensure that the tests build successfully.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant