Fix: Made it so that it reads the JWT and sends the appropriate strin…#370
Open
codingwithmanny wants to merge 2 commits intotwilio:masterfrom
Open
Fix: Made it so that it reads the JWT and sends the appropriate strin…#370codingwithmanny wants to merge 2 commits intotwilio:masterfrom
codingwithmanny wants to merge 2 commits intotwilio:masterfrom
Conversation
added 2 commits
April 3, 2019 11:03
…g for validation, which fixes the invalid token issue
paynerc
suggested changes
Apr 17, 2019
Contributor
paynerc
left a comment
There was a problem hiding this comment.
I would prefer that this token extraction from the JSON happens inside the TokenUtils.fetchToken() method as that method is used in all of the Quickstart projects. This would also then ensure that the returned value from TokenUtils.fetchToken() is actually that, the JWT token.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
Following this tutorial on YouTube: https://www.youtube.com/watch?v=5lrdYBLEk60
This is a proposal for a small fix I noticed when trying to pass the token for establishing a connection.
Error:
Reason For Error:
The reason is because it's not passing just the JWT but the full payload for the JSON string.
Ex:
Fix Includes:
Very primitive fix for just reading the JSON data and assigning the token value to
accessToken.Contributing to Twilio