Skip to content
This repository was archived by the owner on Apr 15, 2025. It is now read-only.

DeleteAuthenticationのRPCを追加#9

Open
hayato24s wants to merge 1 commit intomasterfrom
go/feature/delete-authentication
Open

DeleteAuthenticationのRPCを追加#9
hayato24s wants to merge 1 commit intomasterfrom
go/feature/delete-authentication

Conversation

@hayato24s
Copy link
Copy Markdown
Contributor

@hayato24s hayato24s commented Aug 13, 2023

DeleteAuthenticationのRPCを追加しました。

DB上のユニーク制約

user_authenticationsテーブルに対して(provider,social_id)(user_id,provider)を付与してみたのですがどうでしょうか?

ALTER TABLE user_authentications ADD CONSTRAINT uq_user_authentications_provider_social_id UNIQUE (provider, social_id);

ALTER TABLE user_authentications ADD CONSTRAINT uq_user_authentications_user_id_provider UNIQUE (user_id, provider);

.proto

https://github.com/twin-te/user-service/blob/go/feature/delete-authentication/server/pb/UserService.proto

@hayato24s hayato24s requested review from SIY1121 and takonasu August 13, 2023 13:33
Copy link
Copy Markdown
Member

@takonasu takonasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQLはよいと思います!
Goの方に関しては分からずレビューができずですmm

@takonasu
Copy link
Copy Markdown
Member

@SIY1121 のレビューもお願いしますmm

Copy link
Copy Markdown
Member

@SIY1121 SIY1121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

自分もgoのレビューはできませんが、良いと思います。

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants