Skip to content

Exit with code 2 when an inventory file or url cannot be read and logging enhancements#942

Merged
tristanlatr merged 7 commits intomasterfrom
751-improve-intersphinx-related-error-handling-and-reporting
Jan 24, 2026
Merged

Exit with code 2 when an inventory file or url cannot be read and logging enhancements#942
tristanlatr merged 7 commits intomasterfrom
751-improve-intersphinx-related-error-handling-and-reporting

Conversation

@tristanlatr
Copy link
Copy Markdown
Contributor

@tristanlatr tristanlatr commented Nov 19, 2025

When an inventory file fails to read, log the error and continue without the information instead of printing the whole stack trace.

Improve the error reporting of intersphinx related failures. The -v flag will log exceptions' tracebacks.

Fixes #751

When an inventory file fails to read, log the error and continue without the information instead of crashing.

Improve the error reporting of intersphinx related failures. The -v flag will log exceptions' tracebacks.
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.37%. Comparing base (c1e68f8) to head (d3d7125).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #942      +/-   ##
==========================================
+ Coverage   93.33%   93.37%   +0.03%     
==========================================
  Files          48       48              
  Lines        8912     8931      +19     
  Branches     1636     1639       +3     
==========================================
+ Hits         8318     8339      +21     
+ Misses        337      336       -1     
+ Partials      257      256       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@tristanlatr
Copy link
Copy Markdown
Contributor Author

This PR is missing a change log entry

@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown

Diff from pydoctor_primer, showing the effect of this PR on open source code:

twisted (https://github.com/twisted/twisted): typechecking got 1.05x slower (271.4s -> 285.9s)
(Performance measurements are based on a single noisy sample)

@tristanlatr tristanlatr merged commit 6c94a65 into master Jan 24, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't raise exceptions when offline

1 participant