Exit with code 2 when an inventory file or url cannot be read and logging enhancements#942
Merged
tristanlatr merged 7 commits intomasterfrom Jan 24, 2026
Conversation
When an inventory file fails to read, log the error and continue without the information instead of crashing. Improve the error reporting of intersphinx related failures. The -v flag will log exceptions' tracebacks.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #942 +/- ##
==========================================
+ Coverage 93.33% 93.37% +0.03%
==========================================
Files 48 48
Lines 8912 8931 +19
Branches 1636 1639 +3
==========================================
+ Hits 8318 8339 +21
+ Misses 337 336 -1
+ Partials 257 256 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…ling-and-reporting
This comment has been minimized.
This comment has been minimized.
…ling-and-reporting
This comment has been minimized.
This comment has been minimized.
…ling-and-reporting
This comment has been minimized.
This comment has been minimized.
…ling-and-reporting
Contributor
Author
|
This PR is missing a change log entry |
This comment has been minimized.
This comment has been minimized.
|
Diff from pydoctor_primer, showing the effect of this PR on open source code: twisted (https://github.com/twisted/twisted): typechecking got 1.05x slower (271.4s -> 285.9s)
(Performance measurements are based on a single noisy sample)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an inventory file fails to read, log the error and continue without the information instead of printing the whole stack trace.
Improve the error reporting of intersphinx related failures. The -v flag will log exceptions' tracebacks.
Fixes #751