Remove LZO global lock "hack" that was for an old JVM bug#128
Open
skwslide wants to merge 1 commit intotwitter:masterfrom
Open
Remove LZO global lock "hack" that was for an old JVM bug#128skwslide wants to merge 1 commit intotwitter:masterfrom
skwslide wants to merge 1 commit intotwitter:masterfrom
Conversation
Collaborator
|
Thanks for reporting the issue and also providing the fix. It's a good find, and the fix LGTM. I am no longer at Twitter, and ideally a Twitter engineer should also approve this and merge it. |
Contributor
|
Looks reasonable indeed. Builds locally. I'll try to test this on a cluster and see if I can tell any performance difference, report back and merge (assuming positive results). |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LzoCompressor and LzoDecompressor have a global lock protecting all GetDirectBufferAddress calls. This PR removes the global lock.
Apparently, the global lock's origin is HADOOP-3604, to work around JDK-6852404, but which has been fixed for several years in all Java versions.
The global lock imposes a severe performance penalty in a highly multithreaded environment. I have a Java process with 64 threads on a 64-core machine to decompress LZO files concurrently, and around half of the threads are blocked on the global lock at any moment. The problem is not observed in a 16-way concurrency setup.