Mark dlsym with __attribute__((noinline)).#2
Open
eatnumber1 wants to merge 1 commit intotwosigma:masterfrom
Open
Mark dlsym with __attribute__((noinline)).#2eatnumber1 wants to merge 1 commit intotwosigma:masterfrom
dlsym with __attribute__((noinline)).#2eatnumber1 wants to merge 1 commit intotwosigma:masterfrom
Conversation
In some circumstances (e.g. under higher optimization modes when compiled with LLVM), `dlsym` gets inlined into `libvirtcpuid_init_dso`. When this happens, dlsym's use of `__builtin_return_address(0)` no longer returns the address of `dlsym` and instead returns the address of `libvirtcpuid_init_dso`. When that happens, `_dl_sym` fails to find the next `dlsym` and the process crashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some circumstances (e.g. under higher optimization modes when
compiled with LLVM),
dlsymgets inlined intolibvirtcpuid_init_dso.When this happens, dlsym's use of
__builtin_return_address(0)nolonger returns the address of
dlsymand instead returns the address oflibvirtcpuid_init_dso. When that happens,_dl_symfails to find thenext
dlsymand the process crashes.