Skip to content

Fix issue manual capture and image select buttons disappearing on load #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix issue manual capture and image select buttons disappearing on load #147

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17e38a5
Fix issue capture and select buttons disappearing on load
Jun 12, 2024
5944fbc
Revert "Fix issue capture and select buttons disappearing on load"
Jun 12, 2024
cc52f28
Fix issue capture and select buttons disappearing on load
Jun 12, 2024
2725e48
Remove unecessary self
Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Sources/CodeScanner/ScannerViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,8 @@ extension CodeScannerView {
previewLayer.videoGravity = .resizeAspectFill
view.layer.addSublayer(previewLayer)
addViewFinder()

addManualButtons()

reset()

if !captureSession.isRunning {
Expand Down Expand Up @@ -289,6 +290,11 @@ extension CodeScannerView {
imageView.heightAnchor.constraint(equalToConstant: 200),
])
}

private func addManualButtons() {
self.view.bringSubviewToFront(manualCaptureButton)
self.view.bringSubviewToFront(manualSelectButton)
}

override public func viewDidDisappear(_ animated: Bool) {
super.viewDidDisappear(animated)
Expand Down Expand Up @@ -353,7 +359,6 @@ extension CodeScannerView {
])
}

view.bringSubviewToFront(manualCaptureButton)
manualCaptureButton.isHidden = !isManualCapture
}

Expand All @@ -368,7 +373,6 @@ extension CodeScannerView {
])
}

view.bringSubviewToFront(manualSelectButton)
manualSelectButton.isHidden = !isManualSelect
}
#endif
Expand Down