Add source and bounding rect to ScanResult #171
+27
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… errors when building for simulator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two changes allow you to know where the
ScanResultcame from (cameravsgallery) and where within the scanner/gallery image the match was found. In my experience this was much more straightforward to work with than thecornersproperty.In my use case this was necessary because I am overlaying my own custom viewfinder and want to ignore scan results from outside the viewfinder when the source is
camera. I can use the bounding rect and compare it to the frame of my custom viewfinder.This also fixes an issue where the
isGalleryPresentedbinding wasn't updating properly on simulators.