Skip to content

Skip local variant detection for remote URL images #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrSkwiggs merged 1 commit into from
Mar 2, 2026
Merged

Skip local variant detection for remote URL images #865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Sources/Ignite/Elements/Image.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,19 @@ public struct Image: InlineElement, LazyLoadable {
/// - Parameters:
/// - path: The user image to render.
/// - description: The accessibility label to use.
/// - isRemote: Whether this is a remote URL (skips local variant detection).
/// - Returns: The HTML for this element.
private func render(path: String, description: String) -> Markup {
private func render(path: String, description: String, isRemote: Bool = false) -> Markup {
var attributes = attributes
attributes.append(customAttributes:
.init(name: "src", value: path),
.init(name: "alt", value: description))

// Remote images don't have local variants (@2x, ~dark), so skip detection.
guard !isRemote else {
return Markup("<img\(attributes) />")
}

let (lightVariants, darkVariants) = findVariants(for: path)

if let sourceSet = generateSourceSet(lightVariants) {
Expand Down Expand Up @@ -139,8 +145,9 @@ public struct Image: InlineElement, LazyLoadable {
if let systemImage {
return render(icon: systemImage, description: description ?? "")
} else if let path {
let isRemote = path.scheme == "http" || path.scheme == "https"
let resolvedPath = publishingContext.path(for: path)
return render(path: resolvedPath, description: description ?? "")
return render(path: resolvedPath, description: description ?? "", isRemote: isRemote)
} else {
publishingContext.addWarning("""
Creating an image with no name or icon should not be possible. \
Expand Down