Fix XML escaping in RSS feed generator#871
Open
jpurnell wants to merge 1 commit intotwostraws:mainfrom
Open
Conversation
Article titles and site metadata containing special XML characters (& < > " ') produced invalid RSS that feed readers rejected. Added xmlEscape() to properly encode non-CDATA text fields in the feed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
&,<,>,",') produced invalid RSS that feed readers rejectedxmlEscape()helper toFeedGeneratorto properly encode non-CDATA text fields (item titles, site name, site description)<![CDATA[...]]>(description, author, tags, content) are unaffectedTest plan
&in article titles is escaped to&in feed outputFeedGeneratortests continue to passxmllint --noouton a real feed containing titles with&characters