Conversation
This patch fixes several eslint warnings and adds the generated sw.js to ignore error.
|
@taylrj Only react/no-find-dom-node warnings are not resolved. I'm curious why u prefer to enforce the rule explicitly. Do u have any plans to migrate the API to react refs? |
|
LGTM. Yes, there's a plan to migrate the API since |
|
The reason why I do the eslint fix is that I would like to enable the linter on CI but the warnings will break it. AFAIK, we need to put the refs on the child elements and use it for offset and height calculation, right? |
In theory, yes. But I haven't figure out the way doing so and keep current behavior at the same time. |
This patch fixes several eslint warnings and adds the generated
sw.js to ignore error.