feat: add lighthouse-ci integration #2227
Open
taylrj wants to merge 9 commits intotwreporter:masterfrom
Open
Conversation
- add lighthouserc.js as the config file - update circleci config to run lighthouse - upgrade the version to v2.1 to add support of `obs`
Contributor
Author
|
To verify This is the report link: https://storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/1660264892332-46113.report.html (only valid within few days). |
Aylie-Chou
reviewed
Aug 17, 2022
Aylie-Chou
reviewed
Aug 17, 2022
Contributor
|
Question: On which step do we expect to get lighthouse report ?
|
Aylie-Chou
reviewed
Aug 17, 2022
This patch add `numberOfRuns` to lighthouserc.js config to decrease measurement variability.
This patch updates mock data to add a benchmark post for page speed measurement.
This page adds article page url link as the other target for collecting metrics in lighthouse measurement.
Contributor
Author
A: after PR launch, before PR merge to master |
This change updates lighthouserc.js to add lighthouse ci server, also updates circleci config to include environment variables.
Aylie-Chou
reviewed
Sep 29, 2022
Aylie-Chou
reviewed
Sep 29, 2022
Aylie-Chou
reviewed
Sep 29, 2022
taylrj
force-pushed
the
feat/lighthouse-ci
branch
from
5b67455 to
4f0fc75
Compare
This patch moves lighthouse ci related codes from `build` to an independent job in circleci config as we want to run lighthouse before PR merged but the `build` job has branch filter.
taylrj
force-pushed
the
feat/lighthouse-ci
branch
from
4f0fc75 to
a507ae0
Compare
This patch adds 'category_set' in a mock data post (slug: russian-invasion-of-ukraine-2022-kid-frequently-asked-questions)
Contributor
Author
|
Thanks for the review, and I suppose it might need some tweaks after performing tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: TWREPORTER-419