Skip to content

Comments

feat: Move application server public key to config#3182

Open
Zyreny wants to merge 1 commit intotwreporter:masterfrom
Zyreny:Zyreny/feat/move-webpush-key-to-config
Open

feat: Move application server public key to config#3182
Zyreny wants to merge 1 commit intotwreporter:masterfrom
Zyreny:Zyreny/feat/move-webpush-key-to-config

Conversation

@Zyreny
Copy link

@Zyreny Zyreny commented Feb 15, 2026

Issue

The application server's public key was hardcoded, which posed a security risk.

Notice

The public key is now configurable via an environment variable, enhancing security and flexibility.

Dependency

No additional dependencies are introduced with this change.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Zyreny, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the handling of the application server's public key to enhance security and maintainability. By externalizing the key into a configurable environment variable, it removes a hardcoded sensitive value from the codebase, making the system more robust and easier to manage in different deployment environments.

Highlights

  • Security Enhancement: The application server's public key, previously hardcoded, is now configurable via an environment variable (APPLICATION_SERVER_PUBLIC_KEY), mitigating a security risk.
  • Configuration Flexibility: The change improves flexibility by allowing the public key to be managed externally, rather than requiring code modifications for updates.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • config.js
    • Added applicationServerPublicKey to the module exports, allowing it to be set via process.env.APPLICATION_SERVER_PUBLIC_KEY with a fallback default value.
  • src/components/web-push.js
    • Removed the hardcoded applicationServerPublicKey and replaced it with a reference to process.env.APPLICATION_SERVER_PUBLIC_KEY.
    • Removed a TODO comment related to moving the key to config.
  • webpack.config.js
    • Included process.env.APPLICATION_SERVER_PUBLIC_KEY in the webpack.DefinePlugin configuration, ensuring the key is correctly injected into the client-side bundle during compilation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist
Copy link

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@Zyreny Zyreny changed the title Move application server public key to config feat: Move application server public key to config Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant