Security improvements for Pod Security Standard restricted support and do not mount service account tokens #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update helm_release.yaml
…andard restricted support). Do not automount service account token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of running the Docker Registry in a namespace where Pod Security Standard restricted profile is in use and Istio is injecting a sidecar, the seccompProfile needs to be constrained. This change to values.yaml has no effect if Istio is not being used.
Also, to address best practices for securing a Helm chart, the mounting of service account tokens should not be performed unless it is needed. Since this application does not appear to use it, it can be disabled (value of false). Removing it in both the service account and the deployment (pod) definition is the recommended security guideline.