feat: existing secret support #185
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gridness
added a commit
to Gridness/docker-registry-helm
that referenced
this pull request
Sep 17, 2025
- Fixed a bug found in pull request twuni#185 where if an existing secret was defined, its data wasn't mounted to the deployment and env vars referencing to the auth credentials location inside containers were not created - Fixed multiple whitespace and indenation issues during templating when specifying custom fields for existing secrets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for using an existing Kubernetes Secret for Docker Registry credentials and configuration, instead of always creating a new one. This makes it easier to manage secrets externally and improves flexibility for deployments. The documentation, templates, and values have all been updated to reflect this new option.
Key changes include:
Support for Existing Secret:
existingSecretvalue invalues.yamland documented its usage inREADME.md, allowing users to specify the name of a pre-existing Kubernetes Secret for registry credentials. [1] [2]_helpers.tplto use the newdocker-registry.secretNametemplate, which chooses between the existing secret and the default generated secret. [1] [2] [3] [4] [5] [6]Template and Resource Adjustments:
secret.yamlto only create a new Secret ifexistingSecretis not set, preventing duplicate or unnecessary secrets. [1] [2]deployment.yamlandcronjob.yamlto only annotate with the secret checksum when a new secret is created, ensuring correct rolling updates. [1] [2]NOTES.txtto inform users when an existing secret is being used, with a reminder about required keys.Version Bump:
3.1.0to reflect the new feature.