Remove deprecated dependency: Textrue's Embeddium Options #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Embeddium 3.16+ adds similar functionality to TEO, and as such the mod is discontinued and Embeddium no longer supports loading it. As such, Embeddium/Magnesium Extras no longer works as is. The modification here allows it to still work; all it does is remove the deprecated dependency. The Embeddium dependency should be updated to require version 3.16+ alongside this change.
|
You may also need to remove its reference in the build.gradle file, I'm not sure though. Hopefully this gets looked at soon! |
Author
Done. Mod seems pretty inactive, so not keeping my hopes up - but this will save them some grunt work if they come back to it. |
…endency Mod will now require Embeddium 0.3.16+ since it has the same functionality as TEO for previous versions.
|
how do i download this version? |
Author
|
how do i download this version?
I can't compile a .jar since that'd be infringing on the original creators' rights to this mod, but you can open the latest .jar using 7zip or similar and make the same edits using your favorite text/code editor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embeddium 0.3.16 adds similar functionality to TEO, and as such the mod is discontinued and Embeddium no longer supports loading it. As such, Embeddium/Magnesium Extras no longer works as is. (See issues #63 and #67)
The modification here allows it to still work; all it does is remove the deprecated dependency, and the Embeddium dependency allows it to still run without issues. The Embeddium dependency is also updated to require version 0.3.16 or later alongside this change, as it will break on prior versions due to not having TEO-like functionality.