Skip to content

Rename binary_chop to Array#binary_find_index #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Rename binary_chop to Array#binary_find_index #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions lib/binary_search/pure.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,18 @@
class Array
def binary_index(target)
binary_chop { |v| target <=> v }
binary_find_index { |v| target <=> v }
end

def binary_search(&block)
index = binary_chop(&block)
index = binary_find_index(&block)
index ? self[index] : nil
end

private

def binary_chop(&block)
def binary_find_index(&block)
upper = self.size - 1
lower = 0

while(upper >= lower) do
while upper >= lower
idx = lower + (upper - lower) / 2
comp = yield self[idx]

Expand Down