Add analyze endpoint and query structure #231
Conversation
proto/analyze.proto
Outdated
| Match match = 1; | ||
| Insert insert = 2; | ||
| Put put = 3; | ||
| Update update = 4; | ||
| Delete delete = 5; | ||
| Select select = 6; | ||
| Sort sort = 7; | ||
| Require require = 8; | ||
| Offset offset = 9; | ||
| Limit limit = 10; | ||
| Distinct distinct = 11; | ||
| Reduce reduce = 12; | ||
| } | ||
|
|
||
| // They're all the same structure. Should we just use one? | ||
| message Match { | ||
| uint32 block = 1; | ||
| } | ||
| message Insert { | ||
| uint32 block = 1; | ||
| } | ||
| message Put { | ||
| uint32 block = 1; | ||
| } | ||
| message Update { | ||
| uint32 block = 1; | ||
| } |
There was a problem hiding this comment.
Match, insert, put and update are just one block. They could all be represented by the message.
Should we or just keep them separate?
krishnangovindraj
force-pushed
the
query-structure
branch
from
1327dc8 to
a2cd43a
Compare
| NamedRole named_role = 4; | ||
| // Error condition. Should be unreachable. | ||
| string unresolved = 5; | ||
| } |
There was a problem hiding this comment.
Much better handling of NamedRole.
Unresolved should currently never be reachable, but I've left it there for the error branch in core instead of using an unreachable! there. Should I just remove it?
| Reduce reduce = 12; | ||
| } | ||
|
|
||
| // They're all the same structure. Should we just use one? |
There was a problem hiding this comment.
I quite like them separate! In Rust itll be very easy to unpack them identically
|
|
||
| package typedb.protocol; | ||
|
|
||
| message ConjunctionStructure { |
There was a problem hiding this comment.
Since this is only used for analyze and for structure - i think a better name for the file is probably structure.proto?
|
|
||
| message PipelineAnnotations { | ||
| repeated ConjunctionAnnotations conjunctions = 1; | ||
| message ConjunctionAnnotations { |
There was a problem hiding this comment.
Should we try to move this to the Conjunction?
Structure and Annotations have the same structure and are just unzipped. I don't see a great reason to keep it this way.
2 participants
Release notes: usage and product changes
Add analyze endpoint and query structure
Implementation
analyze.protoandconjunction.protorecreate the HTTP API structure, for the most part.