Skip to content

Refine Site model fields and reorder SiteManager #3134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahmedasar00 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −6
Open

Refine Site model fields and reorder SiteManager #3134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions django-stubs/contrib/sites/models.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ from typing import Any, ClassVar
from django.db import models
from django.http.request import HttpRequest

SITE_CACHE: Any
SITE_CACHE: dict[int | str, Site]

class SiteManager(models.Manager[Site]):
def get_current(self, request: HttpRequest | None = ...) -> Site: ...
Expand All @@ -13,8 +13,10 @@ class SiteManager(models.Manager[Site]):
class Site(models.Model):
objects: ClassVar[SiteManager]

domain = models.CharField(max_length=100)
name = models.CharField(max_length=50)
id: int
domain: str
name: str

def natural_key(self) -> tuple[str]: ...

def clear_site_cache(sender: type[Site], **kwargs: Any) -> None: ...
3 changes: 0 additions & 3 deletions scripts/stubtest/allowlist_todo.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,7 @@ django.contrib.sessions.models.Session.get_next_by_expire_date
django.contrib.sessions.models.Session.get_previous_by_expire_date
django.contrib.sessions.models.Session.session_data
django.contrib.sessions.models.Session.session_key
django.contrib.sites.models.Site.domain
django.contrib.sites.models.Site.flatpage_set
django.contrib.sites.models.Site.id
django.contrib.sites.models.Site.name
django.contrib.staticfiles.finders.DefaultStorageFinder.storage
django.contrib.staticfiles.storage.staticfiles_storage
django.core.cache.cache
Expand Down
Loading