Update Field constructor kwargs-only parameters #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of allowed positional parameters was significantly reduced by DRF upstream, but some remain regardless.
sobolevn
reviewed
Oct 18, 2023
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
I think we need a stubtest for this :(
Contributor
Author
|
Agreed, stubtest would help for sure and it's on my radar. I've assigned #434 to myself. |
…gs-only-parameters
Contributor
Author
|
Marking as draft until #493 is merged. |
Contributor
Author
|
Updated this PR. |
intgr
commented
Oct 18, 2023
Comment on lines
51
to
52
| rest_framework.fields.Field.__init__ | ||
| rest_framework.fields.FilePathField.__init__ |
Contributor
Author
There was a problem hiding this comment.
Note: some XxxField.__init__ methods remain because our argument types aren't precise. But I'd rather fix that separately.
sobolevn
approved these changes
Oct 18, 2023
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
stubtest gives a lot of confidence! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
The number of allowed positional parameters of
Fieldclass constructors was significantly reduced by DRF upstream, but some remain regardless.Also correctly reordered arguments where positional args are allowed.
Related issues