Skip to content

Fixing interruption behaviour #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 12, 2023
Merged

Fixing interruption behaviour #3183

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b720a5b
* fixing interruption behaviour
Angel-O Mar 25, 2023
b03e1f8
fmt
Angel-O Mar 25, 2023
4955b51
reducing rangeLength by a factor of 10 to avoid timeout on CI
Angel-O Mar 25, 2023
b785e49
Merge branch 'typelevel:main' into fixing-interruption-behaviour
Angel-O Mar 31, 2023
8182c8e
simplifying stream, using testcontrol
Angel-O Mar 31, 2023
fdc2d16
minor
Angel-O Mar 31, 2023
d0f0a3a
reducing rangeLength by a factor of 10 to prevent timeout on js
Angel-O Mar 31, 2023
ff688be
Update core/shared/src/test/scala/fs2/StreamCombinatorsSuite.scala
Angel-O Apr 2, 2023
c73ab66
removing unused ref
Angel-O Apr 2, 2023
b64eb5a
downstreamtimeout
Angel-O Apr 2, 2023
8d57590
adding assertion
Angel-O Apr 2, 2023
9ae18d7
supply increase made clear
Angel-O Apr 2, 2023
89889fa
Merge branch 'typelevel:main' into fixing-interruption-behaviour
Angel-O Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/shared/src/test/scala/fs2/StreamCombinatorsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,6 +874,7 @@ class StreamCombinatorsSuite extends Fs2Suite {
source.groupWithin(Int.MaxValue, 1.day)

downstream.compile.lastOrError
.timeout(downstreamTimeout)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this timeout necessary? Since its an executeEmbed test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's because if the test fails we get a slightly better error message

java.util.concurrent.TimeoutException: 7500 milliseconds which can be easily associated to downstreamTimeout

otherwise we get this value on the diff which looks a bit random

_1 = 86405500000000 nanoseconds,

but I'm happy to remove it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, that is a nicer error :) thanks!

.map(_.toList)
.timed
}
Expand Down