Skip to content

Add doc to prePR command alias #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2022
Merged

Add doc to prePR command alias #322

merged 1 commit into from
Jul 2, 2022

Conversation

@armanbilge
Copy link
Member

@armanbilge armanbilge commented Jul 2, 2022

Also use session clear instead of reload at the end.

@armanbilge
Add doc to prePR command alias
0a89b87 
Also use `session clear` instead of `reload` at the end
@mergify mergify bot added the core label Jul 2, 2022
rossabaker
rossabaker approved these changes Jul 2, 2022
View reviewed changes
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what session clear is, but the lack of doc has bitten me many times over the years.

@armanbilge
Copy link
Member Author

armanbilge commented Jul 2, 2022

session clear resets any settings modified in the session (in this case, enabling fatal warnings). It's cheaper than reloading the entire build. H/t #210 (comment)

@armanbilge armanbilge merged commit ca88a51 into series/0.4 Jul 2, 2022
@armanbilge armanbilge deleted the pr/pre-pr-doc branch July 3, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rossabaker rossabaker rossabaker approved these changes

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@armanbilge @rossabaker