Skip to content

fix(server): use correct coordinates in generated POM file #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2024
Merged

fix(server): use correct coordinates in generated POM file #1609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6c6dde
fix(abg): use correct coordinates in generated POM file
Vampire Aug 19, 2024
db55363
Merge branch 'main' into vampire/fix-pom-file
krzema12 Oct 27, 2024
ab70e55
Adjust test
krzema12 Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/workflows/bindings-server.main.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,14 +103,9 @@ workflow(

run(
name = "Compile a Gradle project using the bindings from the server",
// This test depicts the current incorrect behavior, and asserts on
// the Gradle build failing with a specific problem. Once the problem
// is fixed, modify the test to assert on a successful build.
// TODO: https://github.com/typesafegithub/github-workflows-kt/issues/1694
command = """
cd .github/workflows/test-gradle-project-using-bindings-server
(./gradlew build || true) >> output.txt 2>&1
grep "inconsistent module metadata" output.txt
./gradlew build
""".trimIndent(),
)

Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/bindings-server.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,7 @@ jobs:
name: 'Compile a Gradle project using the bindings from the server'
run: |-
cd .github/workflows/test-gradle-project-using-bindings-server
(./gradlew build || true) >> output.txt 2>&1
grep "inconsistent module metadata" output.txt
./gradlew build
- id: 'step-10'
name: 'Fetch maven-metadata.xml for top-level action'
run: 'curl --fail http://localhost:8080/actions/checkout/maven-metadata.xml | grep ''<version>v4</version>'''
Expand Down
2 changes: 1 addition & 1 deletion ...ng-builder/src/main/kotlin/io/github/typesafegithub/workflows/mavenbinding/PomBuilding.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ internal fun ActionCoords.buildPomFile() =
<project xmlns="http://maven.apache.org/POM/4.0.0" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<modelVersion>4.0.0</modelVersion>
<groupId>$owner</groupId>
<artifactId>$fullName</artifactId>
<artifactId>$mavenName</artifactId>
<version>$version</version>
<name>$fullName</name>
<description>Auto-generated binding for $prettyPrint.</description>
Expand Down
Loading