Skip to content

chore: Try removing width limit for emitted yaml #2048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: Try removing width limit for emitted yaml #2048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions github-workflows-kt/src/main/kotlin/io/github/typesafegithub/workflows/yaml/ObjectToYaml.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ internal fun Any.toYaml(): String {
val settings =
DumpSettings
.builder()
// Otherwise line breaks appear in places that create an incorrect YAML, e.g. in the middle of GitHub
// expressions.
.setWidth(Int.MAX_VALUE)
.build()
val writer =
object : StringWriter(), StreamDataWriter {
Expand Down
12 changes: 8 additions & 4 deletions github-workflows-kt/src/test/kotlin/io/github/typesafegithub/workflows/IntegrationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,15 +286,17 @@ class IntegrationTest :
run: 'rm ''.github/workflows/some_workflow.yaml'' && ''.github/workflows/some_workflow.main.kts'''
- id: 'step-2'
name: '[Fallback] Start the local server'
run: 'docker run -p 8080:8080 krzema12/github-workflows-kt-jit-binding-server &'
run: 'docker run -p 8080:8080 krzema12/github-workflows-kt-jit-binding-server
&'
if: '${'$'}{{ steps.step-1.outcome != ''success'' }}'
- id: 'step-3'
name: '[Fallback] Wait for the server'
run: 'curl --head -X GET --retry 60 --retry-all-errors --retry-delay 1 http://localhost:8080/status'
if: '${'$'}{{ steps.step-1.outcome != ''success'' }}'
- id: 'step-4'
name: '[Fallback] Replace server URL in script'
run: 'sed -i -e ''s/https:\/\/bindings.krzeminski.it/http:\/\/localhost:8080/g'' .github/workflows/some_workflow.main.kts'
run: 'sed -i -e ''s/https:\/\/bindings.krzeminski.it/http:\/\/localhost:8080/g''
.github/workflows/some_workflow.main.kts'
if: '${'$'}{{ steps.step-1.outcome != ''success'' }}'
- id: 'step-5'
name: '[Fallback] Execute script again'
Expand Down Expand Up @@ -461,12 +463,14 @@ class IntegrationTest :
uses: 'aws-actions/configure-aws-credentials@v4'
with:
aws-region: 'us-west-1'
role-to-assume: 'arn:aws:iam::1234567890:role/github-actions-role/${'$'}{{ github.token }}'
role-to-assume: 'arn:aws:iam::1234567890:role/github-actions-role/${'$'}{{ github.token
}}'
- id: 'step-3'
uses: 'aws-actions/configure-aws-credentials@v4'
with:
aws-region: 'us-west-1'
role-to-assume: 'arn:aws:iam::12345678901234567890:role/github-actions-role/${'$'}{{ github.token }}'
role-to-assume: 'arn:aws:iam::12345678901234567890:role/github-actions-role/${'$'}{{
github.token }}'

""".trimIndent()
}
Expand Down
Loading