Skip to content

Conversation

@jp06
Copy link

@jp06 jp06 commented Dec 8, 2025

Change Summary

Add support for cross-field ORs by grouping different fields with parentheses () and joining them with ||. Before it will just warn that this is not supported.

I had to implement this for a use case of using separate fields together for a hierarchical multi-level select.

I'm thinking it was a limitation on when this was first written which is why this hasn't implemented yet. Let me know if there are still existing limitations on this that I'm not aware of. Feel free to close if you think this will break stuff.

PR Checklist

@jp06
Copy link
Author

jp06 commented Dec 8, 2025

I noticed this open PR: #260
I got no time to scan this PR, but I will rebase if needed once this is merged.
Unless this is already supported in that PR, will appreciate if someone can let me know. Thanks!

@tharropoulos
Copy link
Collaborator

That PR handles JOINs specifically, but also handles facet filters alongside those. I like this approach more for a starting point myself, could you also add some tests under the testground folder?

@jp06
Copy link
Author

jp06 commented Dec 10, 2025

@tharropoulos Thanks. I actually am thinking of another approach to my problem as I've learned some things, but I can continue this at some points to add some tests on my free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants