feat: add support for join relations in facet and numeric filters (extension of #260) #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * Initial plan * Initial plan for adding join relations support Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Add join relations support to facet and numeric filters Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Remove temporary jest config and update gitignore Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Revert formatting change in FacetSearchResponseAdapter.js Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Remove jest.unit.config.js from .gitignore Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Refactor to eliminate code duplication in join relation handling Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Fix FacetSearchResponseAdapter quotes and eliminate duplicate if statement Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Revert FacetSearchResponseAdapter to single quotes Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Build lib and dist files with join relations support Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com>
) * Initial plan * Add integration tests for numeric refinement list, pagination/sorting, and range filters Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Fix linting issues in integration tests Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Add documentation for new integration tests Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Add comprehensive PR summary documentation Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Remove incorrectly placed test files and revert FacetSearchResponseAdapter Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Add integration tests for joins functionality in testground Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Rename products_with_prices collection to products Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com>
…e filter handling (typesense#3)
…perator (typesense#4) * Initial plan * Initial plan: Refactor ternary operator to check isExcluded first Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Refactor: Check isExcluded first in _buildFacetFilterString ternary operator Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Build: Update dist files after refactoring Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Revert: Undo quote style change in FacetSearchResponseAdapter Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Add DOM tests for joins page Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Revert: Fix quote style in src/FacetSearchResponseAdapter.js Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com>
* fix: configure babel to preserve esm modules instead of converting to cjs • set modules: false in @babel/preset-env to maintain esm syntax • prevents commonjs interop issues when importing from esm contexts • resolves publint warning about __esModule and exports.default pattern * fix(test): let jest still interpret files as cjs --------- Co-authored-by: Fanis Tharropoulos <ftharropoulos@gmail.com> Co-authored-by: Jason Bosco <jason@typesense.org>
…ense#6) * Initial plan * Initial exploration and planning Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Implement join filter grouping by collection Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Revert lib/Configuration.js and lib/support/utils.js to use CommonJS format Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Move join filter grouping to _adaptFilters for cross-filter grouping Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Revert quote style change in src/FacetSearchResponseAdapter.js Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Fix test expectations for _adaptFacetFilters to expect ungrouped output Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Regenerate all lib files from source Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> * Fully regenerate lib files with ESM format Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: OllieJennings <1575448+OllieJennings@users.noreply.github.com>
- add helpers to parse join fields/filters and numeric operators safely - replace brittle regex matches with delimiter scans for special fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
improve regexp handling for join filters of #260, relies on #262
PR Checklist