Fix scoped key generation without parameters #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case generateScopedSearchKey() is called with an empty parameters
array the json encoding would result in '[]' which results in a broken
scoped key and an unhelpful 401 permission error from typesense.
Cast input to an object, so we end up with '{}' for that case.
Contributor
|
Nice! Thanks for adding the test as well @jasonbosco lgtm |
Member
|
Thank you for the PR! Published this in v5.1.0 |
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
In case generateScopedSearchKey() is called with an empty parameters array the json encoding would result in '[]' which results in a broken scoped key and an unhelpful 401 permission error from typesense.
Cast input to an object, so we end up with '{}' for that case.
PR Checklist