feat(document): add ignore_not_found option to delete method
#69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `DeleteSingleDocumentParameters` type definition with `ignore_not_found` flag - update `Document.delete()` method to accept optional parameters - add tests for delete with `ignore_not_found` flag
kishorenc
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
Closes #65
Change Summary
This pull request includes changes to the
typesenselibrary to enhance document deletion functionality and improve testing coverage. The most important changes include adding parameters for deleting a single document, updating the delete method, and adding new tests for the delete functionality.Enhancements to document deletion:
src/typesense/document.py: ImportedDeleteSingleDocumentParametersand updated thedeletemethod to accept optional delete parameters. [1] [2] [3]src/typesense/types/document.py: AddedDeleteSingleDocumentParametersclass to define parameters for deleting a single document.Improvements to testing:
tests/document_test.py: Addedpytestimport and new test cases to verify the delete functionality, including handling non-existent documents and theignore_not_foundparameter. [1] [2] [3]PR Checklist