Skip to content

fix(api): improve error handling for invalid JSON responses #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kishorenc merged 2 commits into from
Apr 28, 2025
Merged

fix(api): improve error handling for invalid JSON responses #84

kishorenc merged 2 commits into from
Apr 28, 2025

Conversation

@tharropoulos
Copy link
Contributor

@tharropoulos tharropoulos commented Apr 23, 2025 •
edited
Loading

Change Summary

Closes #82

  • enhance _get_error_message to handle JSON decode errors
  • add detailed error message including the invalid response text
  • add tests covering valid JSON, invalid JSON, and non-JSON responses

PR Checklist

@tharropoulos
fix(api): improve error handling for invalid JSON responses
0c820a7 
- enhance `_get_error_message` to handle JSON decode errors
- add detailed error message including the invalid response text
- add tests covering valid JSON, invalid JSON, and non-JSON responses
@tharropoulos
refactor(api): fix linting issue with try block
5b32db0
@tharropoulos
Copy link
Contributor Author

tharropoulos commented Apr 28, 2025

@kishorenc

@kishorenc kishorenc merged commit 36b25b2 into typesense:master Apr 28, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kishorenc kishorenc kishorenc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failure to decode Json response from Typesense

2 participants

@tharropoulos @kishorenc