Skip to content

fix: check if headersSent #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
+10 −0
Open

fix: check if headersSent #845

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24989fb
fix: check if headersSent
Leechael Feb 17, 2022
e597f97
chore: warn if headers sent and the default handle still try send res…
Leechael Mar 25, 2022
f63867f
fix: check and ensure response present.
Leechael Mar 25, 2022
60f5e52
fix: response pass through options not action
Leechael Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/driver/express/ExpressDriver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,11 @@ export class ExpressDriver extends BaseDriver {
* Handles result of successfully executed controller action.
*/
handleSuccess(result: any, action: ActionMetadata, options: Action): void {
if (options && options.response && options.response.headersSent) {
console.warn('Response headers were already sent, default handleSuccess will not be executed.');
options.next();
return;
}
// if the action returned the response object itself, short-circuits
if (result && result === options.response) {
options.next();
Expand Down Expand Up @@ -354,6 +359,11 @@ export class ExpressDriver extends BaseDriver {
* Handles result of failed executed controller action.
*/
handleError(error: any, action: ActionMetadata | undefined, options: Action): any {
if (options && options.response && options.response.headersSent) {
console.warn('Response headers were already sent, default handleError will not be executed.');
options.next(error);
return;
}
if (this.isDefaultErrorHandlingEnabled) {
const response: any = options.response;

Expand Down