Subsequent Init runs would clear Husky pre-commit #1520#1521
Open
fgrande wants to merge 1 commit intotypicode:mainfrom
Open
Subsequent Init runs would clear Husky pre-commit #1520#1521fgrande wants to merge 1 commit intotypicode:mainfrom
fgrande wants to merge 1 commit intotypicode:mainfrom
Conversation
|
This is a good use case and addresses my needs. Out of curiosity, would this require any changes in |
Author
|
@Munaf-Divan I haven't added a new test for this in my PR. Maybe it can be nice to have (let me see if I have time to implement it) |
|
Can anyone please merge this PR. This feature is really helpful. The current version almost renders our team project's pre-commit unusable. |
|
I would also like to see this merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
as stated in #1520 I'm sending You a PR.
In my case, we share the same project between many coleagues. If one would run - erroneously - the "init", would delete the pre-commit hook. This is why - IMHO - would be fine to preserve it.
Regards
FabioG