Skip to content

Use strings.Join instead of += in loop #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tangrufus merged 1 commit into from
Nov 9, 2025
Merged

Use strings.Join instead of += in loop #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions or.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package comver

import "strings"

//nolint:godox
// TODO: Make Or to be []Constrainter so that we can nest Or

Expand All @@ -21,15 +23,10 @@ func (o Or) Check(v Version) bool {
}

func (o Or) String() string {
s := ""

ss := make([]string, len(o))
for i := range o {
if i > 0 {
s += " || "
}

s += o[i].String()
ss[i] = o[i].String()
}

return s
return strings.Join(ss, " || ")
}
Loading