Composer v2.9 compatibility #22
Conversation
tangrufus
force-pushed
the
composer-2.9
branch
from
a747cbf to
4a41ef4
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Composer v2.9 by implementing a workaround for HTTP/3 compatibility issues with the WordPress.org API and updating test assertions.
Key changes:
- Adds HTTP/3 workaround in API client to force HTTP/2 usage via SSL options
- Updates test matrix to include Composer 2.9 in both Makefile and GitHub workflows
- Removes "Nothing to install, update or remove" stderr assertions from test files, likely due to output changes in Composer 2.9
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/WpOrg/Api/Client.php | Implements HTTP/3 workaround by adding SSL options to force RemoteFilesystem usage |
| Makefile | Adds php-8.4-composer-2.9 and php-8.3-composer-2.9 to test combinations |
| .github/workflows/test.yml | Adds '2.9' to composer-version matrix |
| testdata/script/*.txtar | Removes "Nothing to install, update or remove" stderr assertions from 6 test files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tangrufus
force-pushed
the
composer-2.9
branch
from
4a41ef4 to
cf34b99
Compare
tangrufus
force-pushed
the
composer-2.9
branch
from
cf34b99 to
dd4b2bc
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@tangrufus I've opened a new pull request, #23, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
close #23 |
Hack to disallow HTTP/3, forcing `HttpDownloader` to use `RemoteFilesystem` instead of `CurlDownloader`.
I suspect api.wordpress.org does not properly support HTTP/3:
$ curl --http1.1 'https://api.wordpress.org/plugins/info/1.2/?action=plugin_information&slug=better-delete-revision'
...json response
$ curl --http2 'https://api.wordpress.org/plugins/info/1.2/?action=plugin_information&slug=better-delete-revision'
...json response
$ curl --http3-only 'https://api.wordpress.org/plugins/info/1.2/?action=plugin_information&slug=better-delete-revision'
...sometimes json response
...but most of the time ERR_DRAINING
curl: (56) ngtcp2_conn_writev_stream returned error: ERR_DRAINING
See:
- composer/composer#12363
- https://github.com/composer/composer/blob/f5854b140ca27164d352ce30deece798acf3e36b/src/Composer/Util/HttpDownloader.php#L537
tangrufus
force-pushed
the
composer-2.9
branch
from
dd4b2bc to
5197c8d
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Hack to disallow HTTP/3, forcing
HttpDownloaderto useRemoteFilesysteminstead ofCurlDownloader.I suspect api.wordpress.org does not properly support HTTP/3:
See: