feat: separe linguify into linguify and linguify-raw#32
feat: separe linguify into linguify and linguify-raw#32ensko merged 4 commits intotypst-community:mainfrom
Conversation
|
P.S. I hope this is good + the tests with tytanic pass (Tried locally) |
ensko
left a comment
There was a problem hiding this comment.
Looks good overall! I agree with most of the formatting, although I generally prefer to separate stuff like that into a separate commit (or PR, but that can be overkill).
The code change was simple enough; you can see my comments regarding the parameters.
Stronger testing would be nice; see the comments there.
Many thanks for your contribution! Let me know if there's anything unclear or something where I could help out with a part.
|
So my understanding is that in the |
|
@SillyFreak I do prefer the original formatting, but I also think that, in every language that has a standard, it should be respected, so I think we should allow the formatter to do its changes. But if you prefer the old formatting I can keep it anyway. And no need to thank me! Its a pleasure, plus I did nothing really big and had to make you lose time on comments x) |
I'm torn on this—it removes something that would be bikeshedded otherwise (see: right here), but in this particular case the code is also shown user-facing in the manual, and the formatting there is thus a bit more of a deliberate choice. The test code is supposed to check that the manual shows correct information, so keeping that code in sync makes sense imo. (But the current manual way of keeping them in sync is of course also not great.) Another viewpoint is that typstyle is still relatively young, so I'm not sure I would call it a standard yet. It surely is the most used Typst formatter though. I'm also reminded of this Reddit comment, itself quoting this blog post:
To me this means that a young formatter should not necessarily be considered the standard outright, but on its way to getting there. In any case, at least for now I feel that the current formatting is fine, and thanks for removing all these other inconsistencies that have crept in!
It's also always a pleasure when other people see something worth to put their time into too, no worries :) |
|
Thanks for the kind words, I like the way you "said" things, never tought of it that way. I guess that for the general public for typst (university notes, papers etc.) the formatter does a wonderful job, but for packages its still meh. I will continue contributing to this with pleasure! Just @ me or If I dont really answer (I dont open github very often) you may as well send me an email or contact me anywhere else. |
Should fix part of what was discussed about in #30.
@SillyFreak I ping you, seems like you'd be happy to see this x)