-
Notifications
You must be signed in to change notification settings - Fork 1
repo: Add RFC process document #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
41833e2
to
a039f98
Compare
This process is adapted from the Rust RFC process on rust-lang/rfcs and is intentionally less formal than that of Rust as the Typst community is still much smaller and the RFCs are less official than those of Rust. The formality may change in the future and the repository may be incorporated into the typst organization itself. But until then, this process can stay simple and somewhat informal.
a039f98
to
241a125
Compare
ac676f1
to
d740c50
Compare
I've put this up for review, but I'd like to discuss the current state of the ecosystem team on the forge before this is merged to ensure we have a representative portion of the community for the final vote of the RFC (as the process stands for now at least). |
We've started pre-nominations for the ecosystem team, see https://github.com/orgs/typst-community/discussions/19 for more information on how the new ecosystem team will be chosen. Once this process is completed, the new ecosystem will vote on this process as its first decision, paving the way for RFCs to be accepted, rejected or postponed. |
8a414db
to
e22ba98
Compare
e22ba98
to
0af7925
Compare
Looking at RFC #6, I think it would be useful to also add a "rendered" link to each PR. Random example from Rust: rust-lang/rfcs#3786 has a link "Rendered" pointing at the author's fork and the Markdown file for more convenient reading. Further suggestion: recommend that RCF PRs start with "RFC: " or a related prefix, e.g. "Draft RFC: " (as an example; that can actually be implied by marking the PR as a draft too) |
We may add a GitHub action to help suggest that: https://github.com/Myriad-Dreamin/tinymist/blob/8be6a12256a18d8c3d170e6cf104ba6e3ef04e9a/.github/workflows/lint-pr-title.yml
|
Yeah, that sounds like a good, I'll add this to the process document.
Perhaps, though I personally tend to write the where, not the what in such a prefix. (I write |
0af7925
to
086763e
Compare
I've updated the process document and added a PR template people can fill out with the link after the PR is created. |
See commit description.
Please make sure to read the source code directly, as some parts of the original text have not yet been altered, these usually have comments which aren't visible in the rendered version.
Two parts in particular stand out:
The Rust process requires consensus by all members of a subteam, since we may not have subteams (see community forge discussion) this would have to be revised.After the review I've changed this to be a sizable majority of the ecosystem team for now.
RFCs need some kind of advertisement when they go into FCP, Rust for example uses the "This Week in Rust" newsletter. See the comment for ideas.I went with the forum as an example here, this need not be just that, it merely serves as an example.
I've also left out the explanation about postponing and informality because they didn't seem to add much and the doc is already long enough. I think we can still simplify a lot of the wording here to make it more approachable.