-
Notifications
You must be signed in to change notification settings - Fork 11
add custom line numbers #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @JL710, thanks for the patch. Can you add a test, corresponding documentation to the README please? The added info should be copied into the NEWS.md as well. |
|
@quachpas I added/updated a unittest and added documentation. Since I never worked with tytantic before I tried my best with the unittest. You might want to special check the unittest changes. |
|
Thanks, that's perfectly fine I'll check it on my side |
quachpas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed the patch. Thank you, it looks nice and I'll be glad to merge this ! I've left comments in the PR for you to look at.
quachpas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I've reviewed the new changes, and that should be the final review. After this, I will merge this.
This PR allows to pass a function that takes a line number and returns content to the line-numbers parameter. Thus allowing users to style the line numbers as they wish.
Example