Skip to content

Conversation

@gomazarashi
Copy link
Contributor

@gomazarashi gomazarashi commented May 18, 2025

#127 への対応です。
気になっている箇所は以下の通りです。

  • formatにおける訳語が冗長な気もしているのですが、色名等の日本語訳はこのまま併記すべきでしょうか?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Japanese translations for the ImageElem documentation in the visualization library, including deprecation notices and ImageScaling enum descriptions.

  • Translate doc comments and deprecation strings into Japanese
  • Localize enum variant explanations for image scaling

Copy link
Member

@kimushun1101 kimushun1101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

内容は問題ないと思います。個人的に思う改善案を追加しました。ご参考になれば幸いです。

gomazarashi and others added 2 commits May 21, 2025 16:22
@gomazarashi
Copy link
Contributor Author

@kimushun1101
ご確認とご提案ありがとうございます!反映させていただきました。

Copy link
Member

@kimushun1101 kimushun1101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応いただきありがとうございました!

@3w36zj6 3w36zj6 merged commit 7f0c16e into typst-jp:main May 21, 2025
3 checks passed
@gomazarashi gomazarashi deleted the translate/image branch May 22, 2025 04:44
@kimushun1101 kimushun1101 added the translation Translation additions or improvements label May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation Translation additions or improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants