Skip to content

Conversation

3w36zj6
Copy link
Member

@3w36zj6 3w36zj6 commented Aug 19, 2025

cf. #233

@3w36zj6 3w36zj6 changed the title docs: rewrite README in English docs: rewrite website README in English Aug 19, 2025
@3w36zj6 3w36zj6 force-pushed the feature/rewrite-website-readme branch from 082b31f to a2468e5 Compare September 17, 2025 11:54
@3w36zj6 3w36zj6 force-pushed the feature/rewrite-website-readme branch from a2468e5 to 3429602 Compare September 17, 2025 12:15
@3w36zj6 3w36zj6 requested a review from Copilot September 17, 2025 12:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR rewrites the website README from Japanese to English, providing comprehensive documentation for the typst-docs-web project. The changes transform a minimal Japanese README into a detailed English guide covering setup, configuration, and usage.

Key changes:

  • Complete rewrite from Japanese to English
  • Added detailed setup instructions with toolchain requirements
  • Expanded documentation with configuration examples and project structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@3w36zj6 3w36zj6 marked this pull request as ready for review September 17, 2025 12:32
@3w36zj6
Copy link
Member Author

3w36zj6 commented Sep 17, 2025

Hi @YDX-2147483647 @Its-Just-Nans
Could you please review this PR?

@3w36zj6 3w36zj6 changed the title docs: rewrite website README in English docs: rewrite typst-docs-web README in English Sep 17, 2025
Copy link
Contributor

@Its-Just-Nans Its-Just-Nans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also make the schema available on https://www.schemastore.org/
https://github.com/SchemaStore/schemastore

^^

@3w36zj6
Copy link
Member Author

3w36zj6 commented Sep 18, 2025

You could also make the schema available on schemastore.org

I just learned about schemastore.org for the first time.

This is not a widely known or "standard" application, so I don't think it is necessary at this time.

Copy link
Contributor

@YDX-2147483647 YDX-2147483647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine! Only soft suggestions.
Please see the third comment below.

<img src="./images/preview.png" alt="">
</div>

A generator that builds a website from a documentation JSON file generated by typst-docs.

This comment was marked as resolved.


```json
{
"$schema": "/path/to/typst-docs-web/metadata.schema.json",

This comment was marked as resolved.

bun run test
```

## Maintainers
Copy link
Contributor

@YDX-2147483647 YDX-2147483647 Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we note the version of typst-docs json somewhere? For example:

The JSON structure generated by typst-docs is not stable.
This project is confirmed to be compatible with typst-docs from v0.13.1 to the dev version on 2025-09-18.
Other versions are usually compatible as well, but they have not been tested carefully.

The typst-docs says the JSON structure is not stable and may change at any time, and it is likely to change soon (because of typst/typst#6922).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good idea to clearly state the supported version.
However, since we don't want to update the README too frequently, I believe it's better to mention only the released versions.
The best approach would be to ensure compatibility by running documentation generation tests for the supported versions in CI.

@3w36zj6 3w36zj6 force-pushed the feature/rewrite-website-readme branch from 6ffdf6c to c19540f Compare September 18, 2025 07:38
Copy link
Member

@kimushun1101 kimushun1101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@3w36zj6 3w36zj6 merged commit 43ca3e3 into main Sep 20, 2025
5 checks passed
@3w36zj6 3w36zj6 deleted the feature/rewrite-website-readme branch September 20, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants