Skip to content

Conversation

@3w36zj6
Copy link
Member

@3w36zj6 3w36zj6 commented Sep 6, 2025

@3w36zj6 3w36zj6 requested a review from Copilot September 6, 2025 01:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a configuration option to control the display of translation status indicators on the website. This allows administrators to toggle translation status visibility while ensuring community content status is always shown.

  • Introduces a new displayTranslationStatus boolean configuration flag
  • Modifies the BaseTemplate component to conditionally render translation status based on the flag

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
website/src/metadata.ts Adds displayTranslationStatus configuration flag defaulting to true
website/src/components/templates/BaseTemplate.tsx Updates rendering logic to conditionally show translation status based on flag

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@3w36zj6
Copy link
Member Author

3w36zj6 commented Sep 6, 2025

Could you do a quick review? @YDX-2147483647

Copy link
Contributor

@YDX-2147483647 YDX-2147483647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but the <Header> (rate of translation) also needs to be updated.

@3w36zj6 3w36zj6 force-pushed the feature/add-translation-status-display-switcher branch from 6eeacb4 to a80b895 Compare September 6, 2025 03:42
Copy link
Contributor

@YDX-2147483647 YDX-2147483647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine now!


Besides, I notice that after removing <TranslationCoverageBadge>, the search bar seemed to lean to the right.

Image

The search bar is mathematically located at the center of the page, but <main> is slightly left aligned, causing this illusion.
In <BaseTemplate>, the width of the left side bar (<SideNavigation>) is lg:w-64, but that of the right side bar (<TableOfContents>) is lg:w-72. Therefore, <main> is not centered.

However, the misalignment is hardly noticeable, and I think it can be ignored.

@3w36zj6 3w36zj6 merged commit 18f7590 into main Sep 6, 2025
5 checks passed
@3w36zj6 3w36zj6 deleted the feature/add-translation-status-display-switcher branch September 6, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants