fix: 画面の横幅が600px以上のときにsidebarを閉じるボタンを非表示にするスタイルを追加
#75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkpoli
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更点
PCサイズの画面幅の環境において、ページの右上に位置している×ボタンは黄色のアラートを閉じるためのボタンのように見えますが、実際にはマークアップ上ではsidebarを閉じるためのボタンであり、#73 でsidebarの開閉のイベントを有効にしたことで、PCサイズの環境で意図しない挙動になってしまっていたため、画面の横幅が
600px以上のときに×ボタンの要素を非表示にする対応を行いました。確認事項
600px以上のときに×ボタンが表示されない