Skip to content

Specify all presentation sequences #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Specify all presentation sequences #114

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ae98eb0
Add variation selectors to symbols that exist in both `sym` and `emoji`
MDLC01 Jul 16, 2025
fabc977
Specify `'static` lifetime when possible
MDLC01 Jul 24, 2025
2062af4
Add tests for variation sequences
MDLC01 Jul 24, 2025
bc90113
Fix variation sequences
MDLC01 Jul 24, 2025
84f7d3e
Download file on build and add `_test-unicode-conformance` feature
MDLC01 Aug 5, 2025
a94ed5b
Only download file if not cached
MDLC01 Aug 7, 2025
2fb667e
Improve code clarity and future-proofness
MDLC01 Aug 11, 2025
0258d05
Add clarification comment
MDLC01 Aug 11, 2025
3fe4ebb
"presentation sequences" -> "emoji variation sequences"
MDLC01 Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,8 @@ mod test {
.collect::<HashSet<_>>();
assert!(
are_all_variants_valid(SYM, |c| {
// All text presentations are exactly 2 codepoints long as of
// Unicode 16.0, so this doesn't miss anything.
!(c.chars().count() == 1
&& require_presentation_selector.contains(&c.chars().next().unwrap()))
}),
Expand All @@ -285,6 +287,8 @@ mod test {
.collect::<HashSet<_>>();
assert!(
are_all_variants_valid(EMOJI, |c| {
// All text presentations are exactly 2 codepoints long as of
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this say "emoji" instead of "text"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed to "emoji variation sequences" everywhere, as this is how text/emoji presentation sequences seem to be referred to by Unicode.

// Unicode 16.0, so this doesn't miss anything.
!(c.chars().count() == 1
&& require_presentation_selector.contains(&c.chars().next().unwrap()))
}),
Expand Down