Skip to content

Implement FromIterator<&str> and Extend<&str> for EcoString#56

Merged
laurmaedje merged 2 commits intotypst:mainfrom
pedrodesu:from-str
Oct 28, 2025
Merged

Implement FromIterator<&str> and Extend<&str> for EcoString#56
laurmaedje merged 2 commits intotypst:mainfrom
pedrodesu:from-str

Conversation

@pedrodesu
Copy link
Contributor

Pretty straightforward idea and implementation. Something I found appropriate and that I found lacking throughout my personal usage of the crate.

@laurmaedje
Copy link
Member

I think if we add this, we should also add Extend<&str> for EcoString and use it in FromIterator<&str>, like in std.

@pedrodesu
Copy link
Contributor Author

Applied the suggested changes.

@laurmaedje laurmaedje changed the title Implement FromIterator<&str> for EcoString Implement FromIterator<&str> and Extend<&str> for EcoString Oct 28, 2025
@laurmaedje laurmaedje merged commit 9639e9f into typst:main Oct 28, 2025
4 checks passed
@pedrodesu pedrodesu deleted the from-str branch October 28, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants