Deploy: don't purge the CDN endpoint #3399
Conversation
It is not necessary anymore, as the archives are now fully immutable, and the correct cache headers are defined for each uploaded file. It was causing the CI to fail these last days because Azure Front Door configuration changes are temporarily forbidden, following the recent outage.
elegaanz
temporarily deployed
to
Package Check
GitHub Actions
Inactive
| with: | ||
| inlineScript: az afd endpoint purge -g Landing-Page --profile-name LandingPage --content-paths '/*' --endpoint-name 'packages' | ||
|
|
||
| - name: logout |
There was a problem hiding this comment.
I'm not sure what was the reason for explicit log out, so I can't really tell if it is still necessary, but installing az just to be able to run az logout seemed a bit useless, so I removed this step too. As far as I can tell, azcopy gets its credentials from environment variables, and I don't think az logout clears that. I don't really think there is a security risk with having these variables set, as this job can only run on the main branch anyways.
There was a problem hiding this comment.
azcopy gets its credentials on line 36 and stores them in the OS trust store if I understood this right so this is fine
| with: | ||
| inlineScript: az afd endpoint purge -g Landing-Page --profile-name LandingPage --content-paths '/*' --endpoint-name 'packages' | ||
|
|
||
| - name: logout |
There was a problem hiding this comment.
azcopy gets its credentials on line 36 and stores them in the OS trust store if I understood this right so this is fine
It is not necessary anymore, as the archives are now fully immutable, and the correct cache headers are defined for each uploaded file.
It was causing the CI to fail these last days because Azure Front Door configuration changes are temporarily forbidden, following the recent outage.