Always use URI pattern matching to extract urls #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix tyru#168. Use URI pattern matching so the trailing ) is excluded in markdown links even when g:openbrowser_allowed_schemes is set. That option should modify how we select schemes (head) and not the uri pattern. Bug introduced in b8d27c7. Test With config: let g:openbrowser_allowed_schemes = [ \ 'https\?', \ 's\?ftp', \ ] These open correct links: -- taken from https://leafo.net/guides/setfenv-in-lua52-and-above.html -- taken from http://leafo.net/guides/setfenv-in-lua52-and-above.html -- taken from ttps://leafo.net/guides/setfenv-in-lua52-and-above.html -- taken from ttps://leafo.net/guides/setfenv-in-lua52-and-above.html * [tyru/open-browser-github.vim](https://github.com/tyru/open-browser-github.vim) This one searches for 'leafo': -- taken from tt://leafo.net/guides/setfenv-in-lua52-and-above.html This opens `https://en.wikipedia.org/wiki/Planetoid_` (which forwards to a valid page) the same behaviour as 91573a3 (before my breaking change): * [Planetoid](https://en.wikipedia.org/wiki/Planetoid_(disambiguation)) The markdown links behave the same way when tested without g:openbrowser_allowed_schemes defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #168.
Use URI pattern matching so the trailing ) is excluded in markdown links even when g:openbrowser_allowed_schemes is set. That option should modify how we select schemes (head) and not the uri pattern.
Bug introduced in b8d27c7.
Test
These open correct links:
Opens
https://en.wikipedia.org/wiki/Planetoid_which Wikipedia correctly redirects. This is the same behaviour as 91573a3 -- before my breaking change.Opens the link if the cursor is on
:and searches for tyru if cursor is on[:This one searches for 'leafo':
(The nonmarkdown links are from b8d27c7.)