WIP: cpud: initial darwin support #296
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Destigmatize darwin cpud by enabling it without filesystem mounts or private namespace. Later can add nfs mounts, binds, and chroot in. Signed-off-by: Eric Van Hensbergen <[email protected]>
rminnich
reviewed
Mar 23, 2025
| // It also requires that CPU_NONCE exist. | ||
| func (s *Session) Namespace() error { | ||
| return fmt.Errorf("CPUD: 9p mounts are only valid on Linux:%w", os.ErrNotExist) | ||
| //return fmt.Errorf("CPUD: 9p mounts are only valid on Linux:%w", os.ErrNotExist) |
There was a problem hiding this comment.
I'm unclear on what the reason for this is. Why is it not an error? Why is the error commented out, if nil is OK?
| package server | ||
|
|
||
| import ( | ||
| "fmt" |
There was a problem hiding this comment.
I'm unsure of the point of this file? Is it for Darwin? Will it fool people into thinking things work? Just trying to understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Destigmatize darwin cpud by enabling it
without filesystem mounts or
private namespace.
WIP: need to add nfs mounts and chroot in order for this to really be cpu and not just an ssh clone
Signed-off-by: Eric Van Hensbergen [email protected]