Skip to content

Issue #17 Contribute BYU Employee Time Reporting and Staff Leave Reporting portlets#18

Open
jameswennmacher wants to merge 13 commits intouPortal-Attic:masterfrom
jameswennmacher:byuContrib
Open

Issue #17 Contribute BYU Employee Time Reporting and Staff Leave Reporting portlets#18
jameswennmacher wants to merge 13 commits intouPortal-Attic:masterfrom
jameswennmacher:byuContrib

Conversation

@jameswennmacher
Copy link

Submitting HRS portlets from BYU:

  • Employee Time Reporting
  • Staff Leave Reporting
    byu-hrportlets

The two portlets are by default wired to an in-memory demo dao data source to allow them to be registered and added to a page for demo purposes. For actual use the dao would need to be replaced with an implementation that calls to Peoplesoft and populates the model, and sends model updates to Peoplesoft.

Notes:

  • Implementation is not ajax-based. That is clearly a desired future feature.
  • Both Leave Reporting controller and javascript calculate totals of rows and columns. Though it is desirable to remove the logic from the controller, this will have to wait for a future time due to budget constraints.

To test:

  • Modify property preAuthenticatedUserDetailsService within bean springSecurityPortletFilterChain in portletApplicationContext.xml to use to avoid having a soap connection to Peoplesoft to get HR Roles. These portlets do not use HR Roles.
  • The portlets can now be built, registered, and added to a tab.
  • The demo dao data sources are very simple. They generate some limited data and process user interactions. Employee Time Reporting adds 5 minutes each clock-in/clock-out cycle. Staff Leave Reporting stores user sick or leave entries.

@apetro
Copy link
Contributor

apetro commented Mar 18, 2014

Would it be better to take this opportunity to go to an org.apereo... package structure, at least for the newly contributed code?

@jameswennmacher
Copy link
Author

That's probably a good idea. Should it be org.apereo or org.jasig since everything else is org.jasig at this point (for consistency)?

@apetro
Copy link
Contributor

apetro commented Mar 18, 2014

This is all new code. If it can't be packaged as org.apereo, perhaps nothing can. :)

For that matter, maybe the boilerplate license headers should reference Apereo rather than Jasig at this point.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the ordering on the List?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order to display on the UI. Good point to clarify in the docs.

@jameswennmacher
Copy link
Author

Updated pull request with feedback, plus adding PortletRequest to dao to allow BYU to use arbitrary user attributes or portlet preferences in their dao implementation. Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet