Add some metadata to ua-parser-py #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masklinn
force-pushed
the
wheel-metadata
branch
from
5204424 to
3bf7f26
Compare
While it's not really in need of documentation as it's an implementation detail of uap-python, opening the link to the dependency from the main package and seeing an empty page is rather suspicious. Adding info / metadata would, I hope and assume, assuage fears. Fixes ua-parser#13
masklinn
force-pushed
the
wheel-metadata
branch
from
3bf7f26 to
1365854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it's not really in need of documentation as it's an implementation detail of uap-python, opening the link to the dependency from the main package and seeing an empty page is rather suspicious.
Adding info / metadata would, I hope and assume, assuage fears.
Fixes #13