Build wheels for both x86 and arm64 for all OS #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masklinn
changed the title
masklinn
force-pushed
the
multiarch
branch
14 times, most recently
from
d04cf84 to
3eb1db4
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
masklinn
force-pushed
the
multiarch
branch
7 times, most recently
from
e9db246 to
1774180
Compare
masklinn
force-pushed
the
multiarch
branch
4 times, most recently
from
2006321 to
7c26283
Compare
masklinn
force-pushed
the
multiarch
branch
2 times, most recently
from
33c2cb2 to
2c616d9
Compare
Necessary to get pypy 3.11 compatibility from pyo3, but since we're at it we might as well update everything.
masklinn
force-pushed
the
multiarch
branch
4 times, most recently
from
7a34eda to
82ffb93
Compare
With the Windows and ARM runners, we should generally not have to cross-compile wheels anymore, and also should be able to test them all (kinda, tests currently not testing musl). - Ensure the wheels we test are the ones we built: previously pip could download previous releases from pypi which misses the point. - Remove caches, building releases is not super common and the caching keys to not retrieve stuff cached for an other archi seems a pain. - Also caching `.cargo/bin` might not be a great idea as apparently some OS end up with rustc in there (?) - Build the test matrix in Python because I'm fed up with trying to get the garbage fire that is GHA declarative matrixes right. That it's possible to do that means it should be possible to generate matrixes from tox tho, something to think about. Also a bunch of targets need to be excluded: - There's currently no graal on windows period. - No pypy on windows/arm. - No 3.9 or 3.10 on windows/arm. Fixes ua-parser#12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.