-
Notifications
You must be signed in to change notification settings - Fork 0
Login/Signup integration #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request implements a comprehensive authentication system using Supabase Auth, integrating email-based user registration and login with email confirmation. The implementation spans backend API endpoints, database integration, frontend UI components, and configuration updates.
Key Changes:
- Backend authentication endpoints (
/auth/signupand/auth/login) with Supabase Auth integration, local profile persistence, and rollback mechanisms - Frontend email confirmation pages with real-time status feedback and extension integration
- Configuration updates for Supabase client initialization and email redirect URLs
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 20 comments.
Show a summary per file
| File | Description |
|---|---|
supabase/config.toml |
Enables email confirmations and adds redirect URLs for the confirmation flow |
frontend/src/popup/LoginPage.jsx |
Adds success message display for signup and auto-switches to login mode after email confirmation |
frontend/src/popup/App.jsx |
Replaces mock authentication with real API calls to backend, handles token storage and refresh |
frontend/src/background/background.js |
Adds message listener for pre-confirmation checks (has duplicate listener issue) |
frontend/public/confirm-email/index.html |
New simplified email confirmation page with status indicators |
frontend/public/confirm-email.html |
New detailed email confirmation page with extension integration and token display |
backend/requirements.txt |
Adds Supabase SDK dependencies and downgrades pydantic version |
backend/app/models/auth.py |
Defines Pydantic models for signup/login requests and responses |
backend/app/core/supabase.py |
Creates singleton Supabase client with service role key |
backend/app/core/config.py |
Adds Supabase configuration settings and email redirect URL |
backend/app/api/routes.py |
Registers authentication router with the API |
backend/app/api/endpoints/auth.py |
Implements signup and login endpoints with error handling, email hashing, and database rollback |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TonyLiu0226
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address remaining copilot comments and then it should be good to merge
|
@copilot open a new pull request to apply changes based on the comments in this thread |
|
@jessiezhou819 I've opened a new pull request, #61, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: jessiezhou819 <115389470+jessiezhou819@users.noreply.github.com>
Address code review comments for authentication system
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 12 out of 13 changed files in this pull request and generated 18 comments.
Files not reviewed (1)
- frontend/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
📝 Description
Brief description of what this PR does.
This pull request introduces a complete authentication system using Supabase Auth, integrating both backend and frontend changes. It adds user registration and login endpoints, securely manages user profiles, and provides a user-friendly email confirmation flow. The update also includes necessary configuration, dependency updates, and a frontend confirmation page.
Backend: Authentication System Integration
New authentication endpoints and logic:
/auth/signupand/auth/loginendpoints inauth.pythat handle user registration and login via Supabase Auth, including error handling, local profile persistence, and rollback on failure.auth.py.routes.py). [1] [2]Supabase integration and configuration:
supabase.pyusing service role keys for admin operations.config.pyto include Supabase and email redirect settings.Dependency updates for authentication:
supabase==2.23.0and its peer dependencywebsockets, and updatespydanticandpsycopg2-binaryversions to ensure compatibility.Frontend: Email Confirmation Flow
confirm-email.htmlin the frontend, providing real-time feedback on email confirmation status and guidance for next steps, including extension integration hooks.🎯 Type of Change
🧪 Testing
📋 Checklist
📸 Screenshots (if applicable)
Screen.Recording.2025-11-22.at.1.11.02.PM.mov
🔗 Related Issues
Closes #(issue number)